Fix CI for Node 20.x #239
Merged
Fix CI for Node 20.x #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mattt. This was what I was thinking of doing, but hestitated for the same reason. How will we remember to come back and unpin? Maybe we should have a PR that reverts the FIXME bit and ship that when it turns green? |
Ooh, yeah. I really like that idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #237
This PR pins the
testjob to the last known good version of Node.js, v20.12.1.This is a problem with the test harness itself (specifically, the
nockdependency), rather than the library. Pinning to an older version isn't ideal, but it's unlikely to hide actual problems with our code. And this unblocks us in the meantime, while we wait for an upstream fix or remove nock entirely.