feat: add preflight for ip forwarding #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we require users to manually enable ip forwarding on their nodes before installing. this preflight checks if ip forwarding is enabled and fails if it is not.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-110749/check-for-ip-forwarding
branch
from
81f5d5c
to
72de1a3
Compare
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
|
@JGAntunes I guess there is overlap between what you are doing and what I am doing. Would you mind reviewing this ? |
ajp-io
approved these changes
Nov 5, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-110749/check-for-ip-forwarding
branch
This was referenced Nov 5, 2024
laverya
added a commit
that referenced
this pull request
Nov 7, 2024
emosbaugh
pushed a commit
that referenced
this pull request
Nov 8, 2024
JGAntunes
pushed a commit
that referenced
this pull request
Nov 8, 2024
we require users to manually enable ip forwarding on their nodes before installing. this preflight checks if ip forwarding is enabled and fails if it is not.
JGAntunes
pushed a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
we require users to manually enable ip forwarding on their nodes before installing. this preflight checks if ip forwarding is enabled and fails if it is not.
Does this PR require a release note?