Require version for helm chart (#183)

* Require version for helm chart

pkg/kots/lint_test.go

@@ -3196,6 +3196,57 @@ spec:
  },
  },
  },
+ {
+ name: "missing required version for Helm extension in embedded cluster config",
+ specFiles: domain.SpecFiles{
+ validPreflightSpec,
+ validConfigSpec,
+ validSupportBundleSpec,
+ validKotsAppSpec,
+ {
+ Name: "ec-config.yaml",
+ Path: "ec-config.yaml",
+ Content: `apiVersion: embeddedcluster.replicated.com/v1beta1
+kind: Config
+spec:
+ version: "v1.2.2+k8s-1.29"
+ roles:
+ controller:
+ name: management
+ labels:
+ management: "true"
+ custom:
+ - name: app
+ labels:
+ app: "true"
+ extensions:
+ helm:
+ repositories:
+ - name: ingress-nginx
+ url: https://kubernetes.github.io/ingress-nginx
+ charts:
+ - name: ingress-nginx
+ chartname: ingress-nginx/ingress-nginx
+ namespace: ingress-nginx
+`,
+ },
+ },
+ expect: []domain.LintExpression{
+ {
+ Rule: "ec-helm-extension-version-required",
+ Path: "ec-config.yaml",
+ Type: "error",
+ Message: "Missing version for Helm Chart extension",
+ Positions: []domain.LintExpressionItemPosition{
+ {
+ Start: domain.LintExpressionItemLinePosition{
+ Line: 20,
+ },
+ },
+ },
+ },
+ },
+ },
  {
  name: "duplicate kots kinds in release",
  specFiles: domain.SpecFiles{

pkg/kots/rego/kots-spec-opa-nonrendered.rego

@@ -424,6 +424,25 @@ lint[output] {
  }
 }
 
+# Check if helm charts in the embedded cluster config contain a version
+lint[output] {
+ rule_name := "ec-helm-extension-version-required"
+ rule_config := lint_rule_config(rule_name, "error")
+ not rule_config.off
+ spec := specs[_]
+ chart := spec.spec.extensions.helm.charts[index]
+ not chart.version
+ field := concat(".", [spec.field, "extensions.helm.charts", string(index)])
+ output := {
+ "rule": rule_name,
+ "type": rule_config.level,
+ "message": "Missing version for Helm Chart extension",
+ "path": spec.path,
+ "field": field,
+ "docIndex": spec.docIndex
+ }
+}
+
 # Check if the kubernetes installer addons versions are valid
 is_kubernetes_installer(file) {
  is_kubernetes_installer_api_version(file.content.apiVersion)