Don't show missing files if no chart was rendered #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FourSigma
reviewed
Sep 27, 2023
| @@ -62,6 +63,7 @@ func LintBuildersRelease(c *gin.Context) { | |||
| continue | |||
| } | |||
|
|
|||
| numChartsRendered += 1 | |||
There was a problem hiding this comment.
Style comment: Any reason for using an integer as a sentinel instead of boolean flag since we just want at least one? Is the count important?
There was a problem hiding this comment.
Makes no difference to me
FourSigma
approved these changes
Sep 27, 2023
divolgin
deleted the
divolgin/sc-87374/for-a-chart-rendering-error-don-t-show-any
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no chart is rendered, we lint an empty set of files which results in warnings like "Missing preflight checks". We want to show those only if at least one chart was rendered successfully. Otherwise only show the rendering errors.