Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy-installs.md explain parameters #1080

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

adamancini
Copy link
Member

Explain all the parameters; in particular noProxy is confusing sitting next to the references to NO_PROXY variable.

https://github.com/replicatedhq/kURL/blob/main/design/proxy.md?plain=1#L47

Explain all the parameters; in particular `noProxy` is confusing sitting next to the references to NO_PROXY variable.

https://github.com/replicatedhq/kURL/blob/main/design/proxy.md?plain=1#L47
@adamancini adamancini requested a review from a team as a code owner December 23, 2024 16:34
@adamancini adamancini added the type::docs Improvements or additions to documentation label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

@github-actions github-actions bot temporarily deployed to preview December 23, 2024 16:38 Inactive
Copy link
Collaborator

@jtuchscherer jtuchscherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@adamancini adamancini merged commit 47e354a into main Dec 24, 2024
4 checks passed
@adamancini adamancini deleted the adamancini-patch-proxy-installs branch December 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::chore type::docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants