Adjusts caching on the EC version to avoid errors #358
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR ----- Updates the function for fetching the EC version to check the right variable when catching Details ------- We were getting some download errors on the Embedded Cluster. It was sporadic and there were a couple of options. The first was GitHub rate limits, which may still be a factor. The second was that the version was either not being fetched or being fetched incorrectly. Investigating the second option, I realized that the code that checked the runtime variable for the version was checking the wrong variable. This change checks the right variable there. I'm not 100% sure this will be a lasting fix to the issue, but it was a bug and it was in the right area. The code also updates the track checksum (since it changes with every push) and fixes an error where the config help text had some variable interpolation problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updates the function for fetching the EC version to check the right
variable when catching
Details
We were getting some download errors on the Embedded Cluster. It was
sporadic and there were a couple of options. The first was GitHub rate
limits, which may still be a factor. The second was that the version was
either not being fetched or being fetched incorrectly.
Investigating the second option, I realized that the code that checked
the runtime variable for the version was checking the wrong variable.
This change checks the right variable there. I'm not 100% sure this will
be a lasting fix to the issue, but it was a bug and it was in the right
area.
The code also updates the track checksum (since it changes with every
push) and fixes an error where the config help text had some variable
interpolation problems.