Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nginx from 1.14.2 #652

Closed
wants to merge 27 commits into from
Closed

Update Nginx from 1.14.2 #652

wants to merge 27 commits into from

Conversation

dydx
Copy link
Member

@dydx dydx commented Oct 16, 2024

Re: https://app.shortcut.com/replicated/story/109666/upgrade-nginx-eol-obsolete-software-nginx-1-14-x-detected

  • Updates from python:2 to python:3 to enable installation of more recent Nginx (1.22.1)
  • Ensures python3 and pip3 are available for make commands
  • Ensures python3 and pip3 are used in make commands
  • Updates packages in requirements.txt
  • Removes no-longer-present version in setup_remote_docker

Testing

Tested the Docker build by adding portions of build_staging_docker_image Job to the pull-request Workflow

Screenshot 2024-10-16 at 22 22 26

Screenshot 2024-10-16 at 22 23 23

Locally, I am now able to run make build and obtain the nginx version:

docker run --rm -it docker.io/library/install-scripts:latest bash -c "nginx -v"     (⎈|eks-production.tail1ed40.ts.net:default)
nginx version: nginx/1.22.1

@dydx dydx self-assigned this Oct 16, 2024
@dydx dydx requested a review from divolgin October 17, 2024 15:02
@dydx dydx requested review from emosbaugh and laverya and removed request for emosbaugh October 17, 2024 15:02
@dydx dydx closed this Oct 17, 2024
@dydx
Copy link
Member Author

dydx commented Oct 17, 2024

This idea was a tiger pit when getting into Okteto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants