-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs around the Subnet Available collector and analyzer #473
Conversation
Holding on the docs review until Evans has a chance to review, but wanted to ask if this new topic might also need to be manually added to the TOC? Asking because I did not see it in the TOC in the Netlify preview (I think it's supposed to be in this section): https://deploy-preview-473--troubleshoot-sh.netlify.app/docs/host-collect-analyze/overview/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM. We'll want to wait for the feature to be released first before merging though
@CpuID Looks good! I just made some minor edits to your content to reflect our style guide. Two things I think are missing:
Lmk when you're ready for a final review. |
thanks @jonquil2002 :) |
I'll sort out getting this on the TOC, I missed that one 👍 |
page + fix spacing of description
Sorted out the TOC + a few other outstanding items mentioned above, thanks @jonquil2002 @paigecalvert This is ready to merge once replicatedhq/troubleshoot#1004 is released 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
heads up: replicatedhq/troubleshoot#1004 is merged but not released yet holding on a merge of this PR until it's released |
Released, 0.59.0 |
Self explanatory.
Should be merged with a release of replicatedhq/troubleshoot#1004 (with the version number it was introduced?)