Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs around the Subnet Available collector and analyzer #473

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Conversation

CpuID
Copy link
Contributor

@CpuID CpuID commented Feb 17, 2023

Self explanatory.

Should be merged with a release of replicatedhq/troubleshoot#1004 (with the version number it was introduced?)

@CpuID CpuID self-assigned this Feb 17, 2023
@CpuID CpuID added the type::feature New feature or request label Feb 17, 2023
@CpuID CpuID requested a review from banjoh February 17, 2023 10:38
@paigecalvert
Copy link
Contributor

Holding on the docs review until Evans has a chance to review, but wanted to ask if this new topic might also need to be manually added to the TOC? Asking because I did not see it in the TOC in the Netlify preview (I think it's supposed to be in this section): https://deploy-preview-473--troubleshoot-sh.netlify.app/docs/host-collect-analyze/overview/

banjoh
banjoh previously approved these changes Feb 17, 2023
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM. We'll want to wait for the feature to be released first before merging though

@jonquil2002
Copy link
Contributor

@CpuID Looks good! I just made some minor edits to your content to reflect our style guide.

Two things I think are missing:

Lmk when you're ready for a final review.

@CpuID
Copy link
Contributor Author

CpuID commented Feb 22, 2023

I just made some minor edits to your content to reflect our style guide.

thanks @jonquil2002 :)

@CpuID
Copy link
Contributor Author

CpuID commented Feb 22, 2023

I'll sort out getting this on the TOC, I missed that one 👍

banjoh
banjoh previously approved these changes Feb 22, 2023
@jonquil2002
Copy link
Contributor

@CpuID @banjoh lmk when you're ready for a final docs review! :)

@CpuID CpuID requested a review from banjoh March 7, 2023 02:57
@CpuID
Copy link
Contributor Author

CpuID commented Mar 7, 2023

Sorted out the TOC + a few other outstanding items mentioned above, thanks @jonquil2002 @paigecalvert

This is ready to merge once replicatedhq/troubleshoot#1004 is released 👍

Copy link
Contributor

@jonquil2002 jonquil2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@CpuID
Copy link
Contributor Author

CpuID commented Mar 10, 2023

heads up: replicatedhq/troubleshoot#1004 is merged but not released yet

holding on a merge of this PR until it's released

@CpuID
Copy link
Contributor Author

CpuID commented Mar 10, 2023

Released, 0.59.0

@CpuID CpuID merged commit f28df73 into main Mar 10, 2023
@CpuID CpuID deleted the cpuid-984 branch March 10, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants