Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for kernel configs host collector and analyzer #563

Merged
merged 3 commits into from
May 31, 2024

Conversation

nvanthao
Copy link
Member

New doc update for replicatedhq/troubleshoot#1546

Copy link

netlify bot commented May 21, 2024

Deploy Preview for troubleshoot-sh ready!

Name Link
🔨 Latest commit eecdfc2
🔍 Latest deploy log https://app.netlify.com/sites/troubleshoot-sh/deploys/6653b6fb7961aa000838aca5
😎 Deploy Preview https://deploy-preview-563--troubleshoot-sh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nvanthao nvanthao self-assigned this May 21, 2024
@nvanthao nvanthao added type::docs Improvements or additions to documentation type::feature New feature or request labels May 21, 2024
paigecalvert
paigecalvert previously approved these changes May 21, 2024
Copy link
Contributor

@paigecalvert paigecalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

- kernelConfigs:
collectorName: "Kernel Configs Test"
strict: true
outcomes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to address replicatedhq/troubleshoot#1546 (review) before merging this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @banjoh, I have updated the doc. Please let me know how it goes.

@nvanthao nvanthao force-pushed the gerard/sc-104829/kernel-config branch from e6a7a68 to eecdfc2 Compare May 26, 2024 22:26
@banjoh banjoh merged commit 7df88ff into main May 31, 2024
5 checks passed
@banjoh banjoh deleted the gerard/sc-104829/kernel-config branch May 31, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::docs Improvements or additions to documentation type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants