ensure Copy collector run last

pkg/collect/collector.go

@@ -286,3 +286,20 @@ func DedupCollectors(allCollectors []*troubleshootv1beta2.Collect) []*troublesho
 	}
 	return finalCollectors
 }
+
+// Ensure Copy collectors are last in the list
+// This is because copy collectors are expected to copy files from other collectors such as Exec, RunPod, RunDaemonSet
+func EnsureCopyLast(allCollectors []Collector) []Collector {
+	otherCollectors := make([]Collector, 0)
+	copyCollectors := make([]Collector, 0)
+
+	for _, collector := range allCollectors {
+		if _, ok := collector.(*CollectCopy); ok {
+			copyCollectors = append(copyCollectors, collector)
+		} else {
+			otherCollectors = append(otherCollectors, collector)
+		}
+	}
+
+	return append(otherCollectors, copyCollectors...)
+}

pkg/supportbundle/collect.go

@@ -121,6 +121,9 @@ func runCollectors(ctx context.Context, collectors []*troubleshootv1beta2.Collec
 		return nil, collect.ErrInsufficientPermissionsToRun
 	}
 
+	// move Copy Collectors if any to the end of the execution list
+	allCollectors = collect.EnsureCopyLast(allCollectors)
+
 	for _, collector := range allCollectors {
 		_, span := otel.Tracer(constants.LIB_TRACER_NAME).Start(ctx, collector.Title())
 		span.SetAttributes(attribute.String("type", reflect.TypeOf(collector).String()))