Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include binary version info in 'version.yaml' troubleshoot file #111

Merged
merged 3 commits into from
Jan 8, 2020
Merged

include binary version info in 'version.yaml' troubleshoot file #111

merged 3 commits into from
Jan 8, 2020

Conversation

laverya
Copy link
Member

@laverya laverya commented Jan 8, 2020 •
edited
Loading

A static file (shown below) really isn't the most useful

apiVersion: troubleshoot.replicated.com/v1beta1
kind: SupportBundle

The proposed change would produce output like this:

apiVersion: troubleshoot.replicated.com/v1beta1
kind: SupportBundle
spec:
  versionNumber: v0.9.15

@laverya laverya requested a review from divolgin January 8, 2020 01:05
marccampbell
marccampbell requested changes Jan 8, 2020
View reviewed changes
@laverya laverya merged commit 30f4d5e into replicatedhq:master Jan 8, 2020
@laverya laverya deleted the include-precise-version-in-troubleshoot-version.yaml branch January 8, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marccampbell marccampbell marccampbell approved these changes

@divolgin divolgin Awaiting requested review from divolgin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laverya @marccampbell