fix(collector): Let pgx library parse TLS parameters #1390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
This allows the collector to respect the sslmode parameters
Reviewer notes
For the postgres collector, we let pgx library parse TLS parameters via its ParseConfig function instead of the collector's default implementation of construction a tls.Config instance for secure connections.
pgx
respects the sslmode parameters when constructing a tls.Config instance. Troubleshoot does not need to do this.We drop the TLS param files to a file and pass them to the library as environment variables, then cleanup after ourselves.
Fix: #1163
Checklist
Does this PR introduce a breaking change?