bug: [sc-103753] Host analysers are not deduplicating during multiple spec merges #1485

[nvanthao]

Description, Motivation and Context

Fixes: #1485

Given spec sb.yaml

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  name: sb
spec:
  analyzers:
  - clusterVersion: {}
  hostCollectors:
  - cpu: {}
  hostAnalyzers:
  - cpu: {}

and command

support-bundle --interactive=false sb.yaml sb.yaml --dry-run

Before

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  creationTimestamp: null
  name: merged-support-bundle-spec
spec:
  analyzers:
  - clusterVersion:
      outcomes: null
  - clusterVersion:
      outcomes: null
  hostAnalyzers:
  - cpu:
      outcomes: null
  - cpu:
      outcomes: null
  hostCollectors:
  - cpu: {}
  - cpu: {}
status: {}

After

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  creationTimestamp: null
  name: merged-support-bundle-spec
spec:
  analyzers:
  - clusterVersion:
      outcomes: null
  hostAnalyzers:
  - cpu:
      outcomes: null
  hostCollectors:
  - cpu: {}
status: {}

Checklist

• New and existing tests pass locally with introduced changes.
• Tests for the changes have been added (for bug fixes / features)
• The commit message(s) are informative and highlight any breaking changes
• Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

• Yes
• No

Duplicated specs with Analyzer, HostCollector and HostAnalayzer will now be merged by their stringified content

[xavpaice]

quick question - how does this interact if there's a url in one of the specs? Just want to confirm that the dedup happens after the url content replaced that particular spec.

[nvanthao]

the dedupe happens after loading URI spec here

troubleshoot/cmd/troubleshoot/cli/run.go

Line 297 in f7ac39f

err := loadSupportBundleSpecsFromURIs(ctx, kinds)

[banjoh]

Ship it