Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow checking kernel versions only in host os analyzer #1585

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jul 23, 2024

Description, Motivation and Context

Add the ability to assert kernelVersion values only without needing to provide the OS distribution. This is will support cases where users want to have a preflight check that checks linux kernel versions regardless of the operating system.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh added the type::feature New feature or request label Jul 23, 2024
@banjoh banjoh requested a review from a team as a code owner July 23, 2024 15:03
@banjoh
Copy link
Member Author

banjoh commented Jul 23, 2024

Here is the docs PR

replicatedhq/troubleshoot.sh#568

Signed-off-by: Evans Mungai <evans@replicated.com>
adamancini
adamancini previously approved these changes Jul 23, 2024
Signed-off-by: Evans Mungai <evans@replicated.com>
adamancini
adamancini previously approved these changes Jul 23, 2024
@DexterYan
Copy link
Member

LGTM

@banjoh banjoh merged commit 0020c11 into replicatedhq:main Jul 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants