feat: etcd collector #1589
feat: etcd collector #1589
Conversation
Makefile
Outdated
| @@ -105,6 +105,9 @@ tidy: | |||
| bin/support-bundle: | |||
| go build ${BUILDFLAGS} ${LDFLAGS} -o bin/support-bundle github.com/replicatedhq/troubleshoot/cmd/troubleshoot | |||
|
|
|||
| bin/support-bundle-linux: | |||
There was a problem hiding this comment.
This is a good addition. Would the target below be better to get all binaries? Builds run in parallel, so additional compiling time should be negligible
build-linux: tidy
@echo "Build cli binaries"
GOOS=linux GOARCH=amd64 $(MAKE) -j bin/support-bundle bin/preflight bin/analyze bin/collect
pkg/collect/etcd.go
Outdated
| Name: "etcd-client", | ||
| Image: "quay.io/coreos/etcd:latest", | ||
| Command: []string{"sleep"}, | ||
| Args: []string{"1d"}, |
There was a problem hiding this comment.
Even if we delete the pod once done, isn't sleeping 1d too long? If deleting fails, say deletion fails or interrupted by user, the pod will be lingering there for a while. A shorter time period like 5m would be better IMO
pkg/collect/etcd.go
Outdated
| Containers: []corev1.Container{ | ||
| { | ||
| Name: "etcd-client", | ||
| Image: "quay.io/coreos/etcd:latest", |
There was a problem hiding this comment.
I think this ought to be passed in as input. In airgap EC environments, we would bundle an etcd image and then pass in the image name to the collector i.e the image would be something like registry.namespace/etcd:tag
There was a problem hiding this comment.
that's a great idea! I've made the requested changes. please let me know how it goes/
nvanthao
force-pushed
the
gerard/sc-109302/etcd-collector
branch
from
7273a35
to
9a88e17
Compare
| "etcdctl endpoint health", | ||
| "etcdctl endpoint status", | ||
| "etcdctl member list", | ||
| "etcdctl alarm list", |
There was a problem hiding this comment.
Can we add etcdctl version here?
Output looks like this
etcdctl version: 3.5.1
API version: 3.5
Description, Motivation and Context
New
etcdcollector that will collect these output from a Kubernetes cluster.Demo: https://www.loom.com/share/6f72f73d983b457eada0044bd19f9406
We only supported distributions that we have access to
etcd:k0scontrollerChecklist
Does this PR introduce a breaking change?