Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log non-existentent analyzers instead of adding to analyzer results #1593

Merged

Conversation

diamonwiggins
Copy link
Member

@diamonwiggins diamonwiggins commented Aug 13, 2024

Description, Motivation and Context

To reduce the amount of noise in the analyzer results where there is an invalid analyzers inside of the spec, we should instead simply log these occurrences behind the debug flag.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@diamonwiggins diamonwiggins requested a review from a team as a code owner August 13, 2024 21:09
@diamonwiggins diamonwiggins merged commit fa14616 into main Aug 14, 2024
27 checks passed
@diamonwiggins diamonwiggins deleted the diamonwiggins/sc-109764/log-missing-analyzer-to-debug branch August 14, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants