Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(support-bundle): add text that explains where support bundle to share #1595

Merged
merged 1 commit into from
Aug 15, 2024
Merged

feat(support-bundle): add text that explains where support bundle to share #1595

merged 1 commit into from
Aug 15, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Aug 15, 2024 •
edited
Loading

Description, Motivation and Context

  • after saved support bundle, it will show extra text to explain the exact support bundle to share.

Demo:

  1. saved message box
Screenshot 2024-08-15 at 5 41 50 PM
  1. After quit the command
Screenshot 2024-08-15 at 5 42 02 PM

sc-109743

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan requested a review from a team as a code owner August 15, 2024 05:42
@DexterYan DexterYan added the type::feature New feature or request label Aug 15, 2024
@DexterYan DexterYan force-pushed the dx/sc-109743/log-location-support-bundle branch from f80d86d to c129f60 Compare August 15, 2024 05:43
@DexterYan DexterYan merged commit 55608c1 into main Aug 15, 2024
27 checks passed
@DexterYan DexterYan deleted the dx/sc-109743/log-location-support-bundle branch August 15, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedge-sparrow hedge-sparrow hedge-sparrow approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DexterYan @hedge-sparrow