Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when analysers fail to match any outcome conditions #1597

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Aug 19, 2024

Description, Motivation and Context

Log whenever no outcome is matched when evaluating analysers

Fixes: #1596

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh requested a review from a team as a code owner August 19, 2024 17:46
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sudo preflight -v=2 sb.yaml
I0820 07:37:33.112108   81346 loader.go:260] Loaded troubleshoot specs successfully
 * [Host OS Info] Running collector...
E0820 07:37:33.129968   81346 analyzer.go:93] no outcome matched for "Host OS Info" host analyzer

============ Collectors summary =============
Succeeded (S), eXcluded (X), Failed (F)
=============================================
Host OS Info (S) : 17ms

============ Redactors summary =============
No redactors executed

============= Analyzers summary =============
Succeeded (S), eXcluded (X), Failed (F)
=============================================
Host OS Info (S) : 0ms

Duration: 21ms
Error: completed with no analysis results

@banjoh banjoh merged commit ff31f5a into replicatedhq:main Aug 20, 2024
27 checks passed
@banjoh banjoh deleted the em/110848-log-empty-analysis branch August 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log when analysers fail to match any outcome conditions
2 participants