Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make load-cluster-specs the default #1602

Merged
merged 23 commits into from
Aug 26, 2024
Merged

feat: make load-cluster-specs the default #1602

merged 23 commits into from
Aug 26, 2024

Conversation

diamonwiggins
Copy link
Member

@diamonwiggins diamonwiggins commented Aug 22, 2024 •
edited
Loading

Description, Motivation and Context

Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.
Screenshot 2024-08-23 at 1 30 40 PM

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@diamonwiggins diamonwiggins requested review from a team as code owners August 22, 2024 23:20
@diamonwiggins diamonwiggins added the type::feature New feature or request label Aug 22, 2024
@diamonwiggins diamonwiggins marked this pull request as draft August 23, 2024 15:07
@diamonwiggins diamonwiggins marked this pull request as ready for review August 23, 2024 17:31
hedge-sparrow
hedge-sparrow requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@hedge-sparrow hedge-sparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor docs typos?

docs/preflight.md Outdated Show resolved Hide resolved
docs/support-bundle.md Outdated Show resolved Hide resolved
banjoh
banjoh approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome change indeed!

LGTM

@diamonwiggins diamonwiggins merged commit e685cb9 into main Aug 26, 2024
27 checks passed
@diamonwiggins diamonwiggins deleted the diamonwiggins/sc-110642/default-load-cluster-specs branch August 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedge-sparrow hedge-sparrow hedge-sparrow approved these changes

@banjoh banjoh banjoh approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diamonwiggins @banjoh @hedge-sparrow