Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): race condition causes tests to fail #1603

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix(e2e): race condition causes tests to fail #1603

merged 2 commits into from
Aug 23, 2024

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Aug 23, 2024 •
edited
Loading

Description, Motivation and Context

E2e tests are failing because podlist returns 0 pods as daemonset is not available. Causes cascading failures in tests.

https://github.com/replicatedhq/troubleshoot/actions/runs/10517322980/job/29142176121

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@emosbaugh emosbaugh requested a review from a team as a code owner August 23, 2024 13:11
banjoh
banjoh approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emosbaugh emosbaugh merged commit 3aaffb4 into main Aug 23, 2024
27 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20240823/e2e-race branch August 23, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emosbaugh @banjoh