Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --redactors flag is dropped if no spec provided #1611

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: --redactors flag is dropped if no spec provided #1611

merged 1 commit into from
Sep 11, 2024

Conversation

diamonwiggins
Copy link
Member

Description, Motivation and Context

Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@diamonwiggins diamonwiggins added type::bug Something isn't working bug::regression labels Sep 11, 2024
@diamonwiggins diamonwiggins requested a review from a team as a code owner September 11, 2024 19:49
@DexterYan DexterYan merged commit 0c63880 into main Sep 11, 2024
27 checks passed
@DexterYan DexterYan deleted the diamonwiggins/fix-redactor-flag-dropped branch September 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DexterYan DexterYan DexterYan approved these changes

@emosbaugh emosbaugh emosbaugh approved these changes

Assignees
No one assigned
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diamonwiggins @emosbaugh @DexterYan