-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analyzer): enable host os info analyzer to support multiple nodes #1618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only 1 nit suggest
the main thing to review here is that we have a ..._nodes.json that lists the nodes which were collected, and the analyzer then uses that to find the appropriate files. We chose this over wildcard as it is more precise, a wildcard could pick up stuff we don't want if we later change the collector to add more files (like raw output). |
Now the code has been improved to create only one file called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description, Motivation and Context
following PR #1608
system/hostos_info_nodes.json
system/nodename/hostos_info.json
Demo Spec
Folders Structure:

Analyzer Result:
Multiple Nodes:

result:
Checklist
Does this PR introduce a breaking change?