-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Remote Host Collection #1633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:replicatedhq/troubleshoot into diamonwiggins/refactor-remote-collectors
DexterYan
reviewed
Oct 7, 2024
DexterYan
reviewed
Oct 7, 2024
banjoh
reviewed
Oct 7, 2024
DexterYan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Uses a global function in the
collect
packagecollect.RemoteHostCollect
instead of a method per collector. This prevents the need to make a change to each collector for now until we have a use case that justifies that level ofgranularityConsiderations
While this PR does prevent the need of having to maintain code for each collector, everything awkward about it i'd attribute to the remote collection code not being closely coupled with each collector. Some examples include:
RBAC
code added. Everywhere else in the codebase this is implemented on a specific type. This code just feels out of place in this implementation, but to be fair, because the same pod is created for each collector its not as dynamic as the other code for standardin-cluster
collectors needs to be. We essentially always verify the same permissions(Can I create a Pod/ConfigMap?)directory
andfilename
, inserting the node name between them, and then saving that. For example,host-collector/system/cpu.json
becomeshost-collector/system/node-name/cpu.json
. This works, for now, but again feels strange, and not sure we'll want to do this longterm. Especially since some collector likerun
have the ability to completely change which file path they use.TODO
Checklist
Does this PR introduce a breaking change?