chore(support-bundle): respect using load-cluster-specs=false

[banjoh]

Description, Motivation and Context

Using ./support-bundle --load-cluster-specs=false still leads to loading support bundle specs from the cluster.

Fixes: #1638

Checklist

• New and existing tests pass locally with introduced changes.
• Tests for the changes have been added (for bug fixes / features)
• The commit message(s) are informative and highlight any breaking changes
• Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

• Yes
• No

[diamonwiggins]

@banjoh any context on this one? FYI i think the reason we decided not to just set the flag to be true by default is because we didn't want there to be any hidden magic taking place if a user did specify additional flags.

Today:

./support-bundle https://some.spec.com would just collect the spec you provided, but with this change it would also load cluster specs. I'd imagine the tests are probably failing for the same reason. Things now being collected from the cluster that we didn't expect.

edit. are you saying that ./support-bundle --load-cluster-specs=false doesn't work today? I could see how in the current code and the conditional being based on args that that could be the case. Its sort of confusing how there are some flags we use directly, but others we convert into args. Either way, if this is what you're trying to address, i agree we should fix. However, we'll probably want to make sure that --load-cluster-specs isn't always true though 🤔

[banjoh]

any context on this one?

As you correctly figured, ./support-bundle --load-cluster-specs=false does not work today, which is what I'm trying to address in this PR. By default, --load-cluster-specs will always be true