Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(support): add missing host collectors for ParseSupportBundle #1656

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(support): add missing host collectors for ParseSupportBundle #1656

merged 3 commits into from
Oct 22, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Oct 21, 2024 •
edited
Loading

Description, Motivation and Context

  • add missing host collectors for ParseSupportBundle

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan requested a review from a team as a code owner October 21, 2024 22:16
@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Oct 21, 2024
@DexterYan DexterYan force-pushed the dx/sc-114419/add-host-collectors branch from 1166e57 to 93ca54a Compare October 21, 2024 22:17
@nvanthao
Copy link
Member

LGTM, just 1 comment for future changes

@nvanthao nvanthao self-requested a review October 21, 2024 23:16
@DexterYan DexterYan merged commit 0d21eed into main Oct 22, 2024
27 checks passed
@DexterYan DexterYan deleted the dx/sc-114419/add-host-collectors branch October 22, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanthao nvanthao nvanthao approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DexterYan @nvanthao