Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not prompt users to save support bundle analysis results #1662

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Oct 25, 2024

Description, Motivation and Context

In interactive mode, do not prompt users to save support bundle analysis results. Users end up providing this file instead of the support bundle archive. The analysis results are contained in the support bundle archive already

Fixes: #1627

Demo: https://asciinema.org/a/hw0j44bwo5jRFllxOJMCmlI67

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

In interactive mode, do not prompt users to save support
bundle analysis results. Users end up providing this file
instead of the support bundle archive. The analysis results
are contained in the support bundle archive already

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh added the type::feature New feature or request label Oct 25, 2024
@banjoh banjoh requested a review from a team as a code owner October 25, 2024 11:51
Copy link
Member

@hedge-sparrow hedge-sparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.

@banjoh banjoh merged commit deda4ce into replicatedhq:main Oct 25, 2024
26 checks passed
@banjoh banjoh deleted the em/do-not-save-sb-results-txt branch October 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop storing support-bundle-results.txt on disk when collecting a support bundle from CLI
2 participants