remove redundant tests #1677
remove redundant tests #1677
Conversation
|
The 3 tests waiting to be reported are the ones I've removed in this PR. |
| @@ -237,18 +237,6 @@ scan: | |||
| --ignore-unfixed \ | |||
| ./ | |||
|
|
|||
| .PHONY: lint | |||
There was a problem hiding this comment.
Wasn't the aim not to run golangci-lint in CI? I think we want to keep this, for manually running it.
There was a problem hiding this comment.
the message we got was that "Org wide, we are not recommending or using golangci-lint". As per this, I've removed it entirely. The results aren't that useful to us.
| @@ -27,25 +27,6 @@ jobs: | |||
| - name: Fails in order to indicate that pull request needs to be marked as ready to review and unit tests workflow needs to pass. | |||
| run: exit 1 | |||
|
|
|||
| test: | |||
There was a problem hiding this comment.
I think we ought to leave at least make vet. we could add it to an existing action such as test-integration
There was a problem hiding this comment.
go test runs vet as step 1 regardless, iiuc.
There was a problem hiding this comment.
https://pkg.go.dev/cmd/go/internal/test "As part of building a test binary, go test runs go vet on the package
and its test source files" - though it does run a subset.
The Makefile that is called with make test includes the make vet as a dependency, I'll add the same to make test-integration.
xavpaice
force-pushed
the
xavpaice/sc-114967/remove-golangci-lint-from-troubleshoot-ci
branch
from
4b03f8f
to
747c88e
Compare
I needed to update |
banjoh
deleted the
xavpaice/sc-114967/remove-golangci-lint-from-troubleshoot-ci
branch
Description, Motivation and Context
Removes some test redundancy, and golangci-lint
Checklist
Does this PR introduce a breaking change?