Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analyzer): add missing warning in outcome #1687

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(analyzer): add missing warning in outcome #1687

merged 3 commits into from
Nov 13, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Nov 12, 2024 •
edited
Loading

Description, Motivation and Context

  • added missing outcome condition for warning
  • added tests for both warning and fail

sc-115535

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Nov 12, 2024
@DexterYan DexterYan requested a review from a team as a code owner November 12, 2024 04:57
@xavpaice xavpaice linked an issue Nov 12, 2024 that may be closed by this pull request
Warn isn't working with regex analyzer #1652
Closed
nvanthao
nvanthao requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit otherwise LGTM

pkg/analyze/text_analyze.go Outdated Show resolved Hide resolved
pkg/analyze/text_analyze.go Outdated Show resolved Hide resolved
pkg/analyze/text_analyze.go Outdated Show resolved Hide resolved
nvanthao
nvanthao approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DexterYan DexterYan merged commit 1a828fa into main Nov 13, 2024
24 checks passed
@DexterYan DexterYan deleted the dx/sc-115535/fix-analyzer-warning branch November 13, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanthao nvanthao nvanthao approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn isn't working with regex analyzer
2 participants
@DexterYan @nvanthao