Run cluster-info in a collector pod #2
Merged
+1,671
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
reviewed
Jul 10, 2019
cmd/troubleshoot/cli/receive.go
Outdated
| } | ||
| } | ||
|
|
||
| if !alreadyReceived { |
There was a problem hiding this comment.
maybe?
if alreadyReceived {
continue
}
divolgin
reviewed
Jul 10, 2019
cmd/troubleshoot/cli/receive.go
Outdated
|
|
||
| decoded, err := base64.StdEncoding.DecodeString(string(body)) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
how about moving on to the next file if this fails
divolgin
reviewed
Jul 10, 2019
|
|
||
| files := make(map[string][]byte) | ||
| if err := json.Unmarshal(decoded, &files); err != nil { | ||
| return err |
There was a problem hiding this comment.
how about moving on to the next file if this fails
divolgin
reviewed
Jul 10, 2019
|
|
||
| paths := make([]string, 0, 0) | ||
| for _, id := range receivedCollectors { | ||
| paths = append(paths, filepath.Join(bundlePath, id)) |
There was a problem hiding this comment.
if some errors are ignored, this should check if path exists
divolgin
reviewed
Jul 10, 2019
| paths = append(paths, filepath.Join(bundlePath, id)) | ||
| } | ||
|
|
||
| if err := tarGz.Archive(paths, "support-bundle.tar.gz"); err != nil { |
There was a problem hiding this comment.
will this overwrite existing bundle with the same name?
There was a problem hiding this comment.
no, it will not . it errors with "support-bundle.tar.gz already exists".
divolgin
reviewed
Jul 10, 2019
| } else { | ||
| for _, foundCollectorJob := range collectorJobs.Items { | ||
| if foundCollectorJob.Spec.Collector.Name == v.GetString("collectors") { | ||
| collectorJob = &foundCollectorJob |
divolgin
approved these changes
Jul 10, 2019
marccampbell
force-pushed
the
collector-job
branch
from
6066771 to
d60de90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.