Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types for vim.js #162

Merged
merged 7 commits into from
Feb 5, 2024
Merged

add types for vim.js #162

merged 7 commits into from
Feb 5, 2024

Conversation

nightwing
Copy link
Collaborator

@nightwing nightwing commented Feb 2, 2024

Sadly this turned out too large, and i had to fix the indentation too, https://github.com/replit/codemirror-vim/pull/162/files?diff=unified&w=1

@nightwing nightwing changed the title start adding types for vim.js add types for vim.js Feb 4, 2024
Copy link
Contributor

@sergeichestakov sergeichestakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exciting, thanks for this!

would be great to eventually rewrite vim.js in TS but we can follow up with that

@nightwing nightwing merged commit 35e3a99 into master Feb 5, 2024
1 check passed
@nightwing nightwing deleted the vim-js-types branch February 5, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants