Bump @electron-forge deps, @types/node #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally figured out why CI is failing. Opened a separate PR with the fix here: #143 |
sergeichestakov
requested review from
a team and
joe-thom
and removed request for
a team
joe-thom
approved these changes
Jan 2, 2024
sergeichestakov
deleted the
@sergeichestakov/update-electron-forge-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're behind a major version for @electron-forge deps, should upgrade to get bug fixes, etc. Also our @types/node has not been updated to reflect the fact that we use Node 20 now.
What changed
Bump @electron-forge deps, @types/node
Test plan
pnpm install+pnpm start