respect indent style preference #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noneofyourbusiness1415252
force-pushed
the
patch-2-leg
branch
from
68c5e44 to
ee30748
Compare
noneofyourbusiness1415252
changed the title
noneofyourbusiness1415252
force-pushed
the
patch-2-leg
branch
3 times, most recently
from
6ffa45a to
027d07d
Compare
|
|
could you uncommit the |
noneofyourbusiness1415252
force-pushed
the
patch-2-leg
branch
from
027d07d to
71db5c2
Compare
jackyzha0
approved these changes
Nov 28, 2023
noneofyourbusiness1415252
force-pushed
the
patch-2-leg
branch
3 times, most recently
from
ea2cd3e to
73b90c2
Compare
|
don't forget to run prettier! CI is failing on style check |
This comment has been minimized.
This comment has been minimized.
returning to appreciating the formatting loading animation :(
noneofyourbusiness1415252
force-pushed
the
patch-2-leg
branch
from
73b90c2 to
1cdc1fe
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas-stubs (https://github.com/pandas-dev/pandas-stubs): typechecking got 1.81x slower (14.6s -> 26.4s)
(Performance measurements are based on a single noisy sample)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make yapf respect indent style preference
tested @ https://replit.com/@UMARismyname/black#f.py