Reapply "Make client accept a function for websocket uri and hadnshakemetadata (#62) (#71) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
masad-frost
and removed request for
a team
blast-hardcheese
force-pushed
the
dstewart/reland-refreshable-metadata
branch
from
de0d5b0
to
a9316c6
Compare
blast-hardcheese
force-pushed
the
dstewart/reland-refreshable-metadata
branch
from
a9316c6
to
1f6efd6
Compare
|
🤷 it's such a small changeset, I'm really surprised we had issues with it before |
masad-frost
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Thank you. Yeah I'm not sure what's going on. I couldn't get back to it, but https://github.com/replit/ai-infra/pull/1884 wasn't passing CI, and your approach should've been essentially a no-op.
If you wanna hold off merging this until I get some cycles to unblock it so we don't have a broken river-python.
|
Totally, just trying to keep things moving. Feel free to take this branch |
blast-hardcheese
added a commit
that referenced
this pull request
Aug 26, 2024
Why === Follow-up to #72 to account for `schema.json` files without metadata. What changed ============ If the `handshakeSchema` field is defined, then the parameter is required. Otherwise, the parameter is `Literal[None]`, which matches the previous behavior of the default. Due to the metadata field now being required, I had to remove the `= None` default parameter. I think this is alright. It'll mean that #73 will likely need to change to `handshake_metadata_factory: HandshakeType | Callable[[], Awaitable[HandshakeType]]` to avoid `async def stub() -> None: return None` just to satisfy the async requirement. It's somewhat challenging to capture the exact semantics we want here, but I think that's alright. Test plan ========= Do typechecks pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want this, but there were issues before. Hopefully the types disambiguate enough to help us over the hump.
What changed
Reland the previous changeset
Test plan
Can we deploy without causing trouble?