Adding a sqlite index fallback #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ertan
reviewed
Dec 7, 2024
ryantm
approved these changes
Dec 7, 2024
blast-hardcheese
force-pushed
the
dstewart/feat/initial-sqlite-search-fallback
branch
from
d514c48 to
56cc047
Compare
blast-hardcheese
force-pushed
the
dstewart/feat/initial-sqlite-search-fallback
branch
from
29218e4 to
5294c50
Compare
blast-hardcheese
deleted the
dstewart/feat/initial-sqlite-search-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Pypi is making some changes to their search index. If we have any issues, we fall back to best effort served from the sqlite database.
What changed
Adding a fallback search result that just serves the package names. TODO is to add download count, but that requires some more thought.
Test plan
does
upm search -l python flaskwork inside a repl?