include download stats in sqlite query #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlinkz
approved these changes
Dec 7, 2024
ryantm
approved these changes
Dec 7, 2024
blast-hardcheese
force-pushed
the
dstewart/include-download-stats-in-sqlite-query
branch
from
1919a90 to
567192e
Compare
blast-hardcheese
force-pushed
the
dstewart/include-download-stats-in-sqlite-query
branch
from
d720f69 to
bcb40b5
Compare
blast-hardcheese
deleted the
dstewart/include-download-stats-in-sqlite-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In an attempt to make the fallback a little nicer without ballooning the database too much, let's include
download_countso we can impose some sort of sensible ordering.I added some heuristics to the query builder to make it feel a little better to use with imprecise queries.
What changed
Add ordering sqlite fallback by
download_countTest plan
CI