ignore python modules made available by existing packages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trusting package guessing leads to an issue where multiple packages providing
the same module can inadvertently be both installed. This happens when different
packages each rank as the best guess for modules provided by the same package.
Although it is somewhat incorrect as transitive deps could cause some packages
to be incorrectly skipped. The end behavior makes things a bit more reliable.
Perhaps it'd better to determine the fewest number of packages to satisfy all
modules, but this seems to work well enough for now.
here's a repl using this new behavior: https://repl.it/@turbio/upm-testing
notice that websocket isn't installed because it is made available by discord