Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n (mod crashing) #654

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Fix i18n (mod crashing) #654

merged 10 commits into from
Nov 14, 2024

Conversation

FedeIlLeone
Copy link
Member

@FedeIlLeone FedeIlLeone commented Nov 11, 2024

Fixes the mod crashing on startup.

  • Huge refactor on Replugged's i18n to adapt to the new discord-intl system: uses two build tools present on the discord-intl repo , that have been rewritten for esbuild, to load and transform the i18n messages to the new format readable with the formatters. This also comes with a types generator, which let's us type our i18n strings perfectly. i18n files are no longer in the bundled asar but instead compiled with the renderer.
  • Added support for es-419 (Español, LATAM).
  • Fixed plaintext patches.
  • Fixed an issue with toasts not being displayed in case an addon fails to enable or disable, due to missing strings or non existent variables.
  • Fixed an issue with the watching mode of an addon which would've showed both success and failed toasts in case the reload failed.
  • Removed node-fetch and @octokit/rest, reducing the size of the built main.js by ~60% (~650kb to ~250kb).
  • Updated dependencies.

@FedeIlLeone FedeIlLeone added bug Something isn't working refactor semver: patch Requires a patch semver version bump labels Nov 11, 2024
@FedeIlLeone FedeIlLeone marked this pull request as ready for review November 12, 2024 17:02
@colin273 colin273 merged commit 3f1c9a7 into main Nov 14, 2024
14 checks passed
@colin273 colin273 deleted the fix-i18n branch November 14, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor semver: patch Requires a patch semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants