Fix the issue with the logs in afterhook #96
Conversation
|
Fix the bug related to #50 and #44 issues. @AmsterGet Please review it. |
|
Hello @NeginMn ! |
| @@ -298,7 +298,6 @@ class ReportportalAgent extends Mocha.reporters.Base { | |||
| this.attributes.delete(this.currentTest.tempId); | |||
| this.descriptions.delete(this.currentTest.tempId); | |||
| this.testCaseIds.delete(this.currentTest.tempId); | |||
| this.currentTest = null; | |||
There was a problem hiding this comment.
Hi, @NeginMn!
Unfortunately, we can not just delete this line of code and make everything work as expected.
Here is the reason:
Mocha provides the status pending for a test without a callback or the tests with descripe.skip or this.skip()(you can read more about it here)
If we remove assignment this.currentTest = null this line of code, wouldn't be executed
and in the RP we will see the following
Tests with pending status started twice, but only one of them was finished.
But it is not the main problem.
We expected, that logs, attachments and etc, would be reported incide afterEach hook, not in the test itself.
But we have the following
It is reported directly inside the test itself.
Here is the afterEach hook itself
Without this.currentTest = null, attachments, logs etc., report on the suit level which also not the best option.
If you have an opportunity and desire you can try to implement attaching meta information to the afterEach hook itself.
Unfortunately, currently, our team doesn't have the capacity to implement this feature. But as soon as we find the capacity, we will try to fix it!
No description provided.