EPRMPP-83651 || Clean storage job out of memory #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, batchSize); | ||
|
|
||
| int attachmentsSize = thumbnails.size() + attachments.size(); | ||
| if (attachmentsSize == 0){ |
There was a problem hiding this comment.
WhitespaceAround: '{' is not preceded with whitespace.
| /** | ||
| * Storage service interface | ||
| */ | ||
| public interface DataStorageService { | ||
| void delete(String filePath) throws Exception; | ||
| void deleteAll(List<String> paths) throws Exception; |
There was a problem hiding this comment.
'method def modifier' has incorrect indentation level 4, expected level should be 2.
|
Kudos, SonarCloud Quality Gate passed!
|
APiankouski
approved these changes
May 18, 2023
APiankouski
added a commit
that referenced
this pull request
Jun 7, 2023
* EPMRPP-81362 || Fix security vulnerabilities (#58) * EPMRPP-81362 || Update gson version to make able jcloud work (#59) * EPMRPP-82673-exec-jar promote.yml update (added exec jar) * Merge master to 5.7.5 (#66) * EPMRPP-80865|| Update bom version * [Gradle Release Plugin] - new version commit: '5.7.5'. * EPMRPP-82673-exec-jar promote.yml update (added exec jar) --------- Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: reportportal.io <support@reportportal.io> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: Ryhor <125865748+rkukharenka@users.noreply.github.com> * Update version * EPMRPP-82707 || Add single bucket configuration (#67) * EPMRPP-82707 || Add single bucket configuration * EPMRPP-82707 || Refactor according to checkstyle * EPMRPP-79722 || Replace RuntimeException with checked exception when file is not found in CleanStorageJob (#68) * Merge master to hotfix/next (#72) * Release 5.8.0 (#71) * EPMRPP-81362 || Fix security vulnerabilities (#58) * EPMRPP-81362 || Update gson version to make able jcloud work (#59) * Merge master to 5.7.5 (#66) * EPMRPP-80865|| Update bom version * [Gradle Release Plugin] - new version commit: '5.7.5'. * EPMRPP-82673-exec-jar promote.yml update (added exec jar) --------- Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: reportportal.io <support@reportportal.io> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: Ryhor <125865748+rkukharenka@users.noreply.github.com> * Update version * EPMRPP-83538 || Job service version is missing on Login page * Update version --------- Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: Ivan Kustau <86599591+IvanKustau@users.noreply.github.com> Co-authored-by: reportportal.io <support@reportportal.io> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: Ryhor <125865748+rkukharenka@users.noreply.github.com> Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> * [Gradle Release Plugin] - new version commit: '5.8.1'. --------- Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: Ivan Kustau <86599591+IvanKustau@users.noreply.github.com> Co-authored-by: reportportal.io <support@reportportal.io> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: Ryhor <125865748+rkukharenka@users.noreply.github.com> Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> * EPRMPP-83651 || Clean storage job out of memory (#74) * EPMRPP-83651 || Create batching for clean storage job * EPMRPP-83651 || Refactor CleanStorageJob * EPMRPP-83651 || Add check for empty attachment_deletion table * EPMRPP-83651 || Clean attachments list every batch * EPMRPP-83651 || Add default value for feature flags * EPMRPP-83651 || Change logic for CleanStorageJob when using multibucket * EPMRPP-83651 || Fix bug interrupting remove files when bucket is not found * EPMRPP-83651 || Refactor CodeStyle * EPMRPP-83098 || Update datastore variables naming (#75) * Update gradle scripts version * Remove dockerPrepareEnvironment --------- Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: Ivan Kustau <86599591+IvanKustau@users.noreply.github.com> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: Ryhor <125865748+rkukharenka@users.noreply.github.com> Co-authored-by: reportportal.io <support@reportportal.io> Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> Co-authored-by: Ivan_Kustau <Ivan_Kustau@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.