Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-77829 - attribute list #3143

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Conversation

renkyoji
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #3143 (b7bcbf4) into develop (985c44d) will increase coverage by 0.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3143      +/-   ##
===========================================
+ Coverage    59.90%   60.58%   +0.68%     
===========================================
  Files           75       75              
  Lines          808      822      +14     
  Branches       119      126       +7     
===========================================
+ Hits           484      498      +14     
  Misses         296      296              
  Partials        28       28              
Impacted Files Coverage Δ
app/src/common/utils/validation/validate.js 97.46% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985c44d...b7bcbf4. Read the comment docs.

@renkyoji renkyoji force-pushed the EPMRPP-77829-attribute-list branch from 6bffddd to 57ded5f Compare June 23, 2022 20:51
@renkyoji renkyoji requested a review from AmsterGet June 26, 2022 20:11
@renkyoji renkyoji force-pushed the EPMRPP-77829-attribute-list branch from fd65575 to 13c986c Compare June 27, 2022 09:38
Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we need to support trailing ... dots (see the screenshot from designs).

image

The same is about red asterisk above the placeholder.

image

@renkyoji renkyoji requested a review from AmsterGet June 27, 2022 15:14
@AmsterGet AmsterGet merged commit 8ae0519 into develop Jun 27, 2022
@AmsterGet AmsterGet deleted the EPMRPP-77829-attribute-list branch June 27, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants