EPMRPP-78220 || Integration plugin empty state. No configured integrations #3219
+339
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivekrodis
requested changes
Aug 8, 2022
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Outdated
Show resolved
Hide resolved
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Show resolved
Hide resolved
...tingsPageContainer/content/integrations/integrationsList/integrationInfo/integrationInfo.jsx
Show resolved
Hide resolved
...ingsPageContainer/content/integrations/integrationsList/integrationInfo/integrationInfo.scss
Outdated
Show resolved
Hide resolved
...ingsPageContainer/content/integrations/integrationsList/integrationInfo/integrationInfo.scss
Outdated
Show resolved
Hide resolved
...ingsPageContainer/content/integrations/integrationsList/integrationInfo/integrationInfo.scss
Outdated
Show resolved
Hide resolved
...ingsPageContainer/content/integrations/integrationsList/integrationInfo/integrationInfo.scss
Outdated
Show resolved
Hide resolved
chivekrodis
requested changes
Aug 8, 2022
app/src/pages/inside/projectSettingsPageContainer/content/integrations/integrations.jsx
Show resolved
Hide resolved
Comment on lines
+38
to
+46
| const documentationList = { | ||
| [JIRA]: 'https://reportportal.io/docs/Jira-Server-Integration%3Eproject-jira-server-integration', | ||
| [RALLY]: 'https://reportportal.io/docs/Rally-Integration%3Eproject-rally-integration', | ||
| [EMAIL]: 'https://reportportal.io/docs/E-mail-server-integration', | ||
| [SAUCE_LABS]: 'https://reportportal.io/docs/Sauce-Labs-integration', | ||
| [JIRA_CLOUD]: | ||
| 'https://reportportal.io/docs/Jira-Cloud-Integration%3Eproject-jira-cloud-integration', | ||
| [AZURE_DEVOPS]: 'https://reportportal.io/docs/Azure-DevOps-BTS', | ||
| }; |
There was a problem hiding this comment.
As we don't have this links in the plugins maybe better extract it to separate map and move somewhere src/components/integrations/constants.js to store it in the one place
JIRA_CLOUD, AZURE_DEVOPS move too
@AmsterGet
There was a problem hiding this comment.
Refer to my previous comment: it will be good to hold such info on plugin side in its details.
So please create a separate task for this and discuss it with BE team and BA.
@chivekrodis please take care about this)
AmsterGet
changed the title
AmsterGet
approved these changes
Aug 8, 2022
| @@ -0,0 +1,2 @@ | |||
| export const JIRA_CLOUD = 'JIRA Cloud'; | |||
| export const AZURE_DEVOPS = 'Azure DevOps'; | |||
There was a problem hiding this comment.
Ideally the core UI shouldn't know any info about certain plugin, its name and description.
Comment on lines
+38
to
+46
| const documentationList = { | ||
| [JIRA]: 'https://reportportal.io/docs/Jira-Server-Integration%3Eproject-jira-server-integration', | ||
| [RALLY]: 'https://reportportal.io/docs/Rally-Integration%3Eproject-rally-integration', | ||
| [EMAIL]: 'https://reportportal.io/docs/E-mail-server-integration', | ||
| [SAUCE_LABS]: 'https://reportportal.io/docs/Sauce-Labs-integration', | ||
| [JIRA_CLOUD]: | ||
| 'https://reportportal.io/docs/Jira-Cloud-Integration%3Eproject-jira-cloud-integration', | ||
| [AZURE_DEVOPS]: 'https://reportportal.io/docs/Azure-DevOps-BTS', | ||
| }; |
There was a problem hiding this comment.
Refer to my previous comment: it will be good to hold such info on plugin side in its details.
So please create a separate task for this and discuss it with BE team and BA.
@chivekrodis please take care about this)
AmsterGet
deleted the
EPMRPP-78220-Integration-plugin-empty-state-no-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.