Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-78764 || Defect types system messages depending on length #3248

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

tr1ble
Copy link
Contributor

@tr1ble tr1ble commented Aug 29, 2022

EPMRPP-78764 || Defect types system messages depending on length, color picker pointer style fix

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #3248 (84b6298) into develop (b81a342) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #3248   +/-   ##
========================================
  Coverage    61.38%   61.38%           
========================================
  Files           73       73           
  Lines          795      795           
  Branches       120      120           
========================================
  Hits           488      488           
  Misses         280      280           
  Partials        27       27           
Impacted Files Coverage Δ
app/src/common/constants/colors.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tr1ble tr1ble requested review from chivekrodis and Vadim73i August 29, 2022 08:47
@Vadim73i
Copy link
Contributor

  1. If user can't create a new defect because of limits, "Create a new Defect" icons should be disabled, not hidden. Tooltip remains.
    https://www.figma.com/file/7Y3Sr3bwJ281dXoRi0Liue/%E2%9A%99%EF%B8%8F-RP6-Project-level?node-id=8087%3A197549

  2. If only 1 slot is available, the text should be "1 slot left" instead of "1 slots left"

@tr1ble
Copy link
Contributor Author

tr1ble commented Aug 30, 2022

  1. If user can't create a new defect because of limits, "Create a new Defect" icons should be disabled, not hidden. Tooltip remains.
    https://www.figma.com/file/7Y3Sr3bwJ281dXoRi0Liue/%E2%9A%99%EF%B8%8F-RP6-Project-level?node-id=8087%3A197549
  2. If only 1 slot is available, the text should be "1 slot left" instead of "1 slots left"
  1. If user can't create a new defect because of limits, "Create a new Defect" icons should be disabled, not hidden. Tooltip remains.
    https://www.figma.com/file/7Y3Sr3bwJ281dXoRi0Liue/%E2%9A%99%EF%B8%8F-RP6-Project-level?node-id=8087%3A197549
  2. If only 1 slot is available, the text should be "1 slot left" instead of "1 slots left"

1, To be honest, I didn't see it on my screen because of brigthness :(
2. I didn't see a behavour where we consider it, Can you give an example ?

@tr1ble
Copy link
Contributor Author

tr1ble commented Aug 30, 2022

  1. If user can't create a new defect because of limits, "Create a new Defect" icons should be disabled, not hidden. Tooltip remains.
    https://www.figma.com/file/7Y3Sr3bwJ281dXoRi0Liue/%E2%9A%99%EF%B8%8F-RP6-Project-level?node-id=8087%3A197549
  2. If only 1 slot is available, the text should be "1 slot left" instead of "1 slots left"

Fixed both, thanks

Copy link
Contributor

@chivekrodis chivekrodis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that's expected result for donut on the launch view
image

Also recheck all widgets as I see old TI color at least on the 'Investigated percentage of launches' widget

@tr1ble
Copy link
Contributor Author

tr1ble commented Sep 1, 2022

Please make sure that's expected result for donut on the launch view image

Also recheck all widgets as I see old TI color at least on the 'Investigated percentage of launches' widget

  1. Yes, as I checked it's OK. For now we don't have updated design for this place
  2. As I checked, everything is fine
    image

@tr1ble tr1ble requested a review from chivekrodis September 1, 2022 08:29
@chivekrodis
Copy link
Contributor

Please make sure that's expected result for donut on the launch view image
Also recheck all widgets as I see old TI color at least on the 'Investigated percentage of launches' widget

  1. Yes, as I checked it's OK. For now we don't have updated design for this place
  2. As I checked, everything is fine
    image

image

@tr1ble
Copy link
Contributor Author

tr1ble commented Sep 1, 2022

Please make sure that's expected result for donut on the launch view image
Also recheck all widgets as I see old TI color at least on the 'Investigated percentage of launches' widget

  1. Yes, as I checked it's OK. For now we don't have updated design for this place
  2. As I checked, everything is fine
    image
image

Thanks, fixed

@chivekrodis chivekrodis merged commit 56dd6f9 into develop Sep 1, 2022
@chivekrodis chivekrodis deleted the EPMRPP-78764_Defect_types_system_messages branch September 1, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants