EPMRPP-79419 || Fixes for automation attributes #3254
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3254 +/- ##
========================================
Coverage 61.38% 61.38%
========================================
Files 73 73
Lines 795 795
Branches 120 120
========================================
Hits 488 488
Misses 280 280
Partials 27 27 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| defaultWidth={false} | ||
| dataAutomationId="longNameField" | ||
| /> | ||
| <FieldErrorHint provideHint={false} dataAutomationId="longNameField"> |
There was a problem hiding this comment.
Why you don't use constants like NAME_FIELD_KEY?
each filed have a name and usually we use a constant for it
Also what the benefit of pass dataAutomationId to FieldErrorHint component and not directly to the FieldText?
In some places you passed dataAutomationId to the FieldElement, some to the FieldErrorHint please use one general way across the whole app
There was a problem hiding this comment.
We need to pass this attribute to upper container. It can be both FieldErrorHint or FieldElement so we pass it depending on the situation. I had this question too and asked Vika. She said that the discussed it with Ilya.
There was a problem hiding this comment.
Attribute should be set to the field container which not only contains the field itself, but also contains field description, error, title, etc. which is related to the field. Some tests will not only work with the field itself, but will also verify the name of the field, the hint under it or the validation error text. So, it will be simpler to find the field container and find all these elements inside of it, than set separate test attribute to each element of each field. It was discussed with Ilya
There was a problem hiding this comment.
No description provided.