EPMRPP-79184 || Tooltip component

[tr1ble]

No description provided.

[codecov-commenter]

Codecov Report

Merging #3316 (e0b89c0) into develop (81da1dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3316   +/-   ##
========================================
  Coverage    61.65%   61.65%           
========================================
  Files           74       74           
  Lines          798      798           
  Branches       121      121           
========================================
  Hits           492      492           
  Misses         279      279           
  Partials        27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[chivekrodis]

Side: top little bit confusing. Maybe be better to change to placement or something similar. No need for any action now, let's see the opinion of other team members

[Vadim73i]

As far as I remember, the position of the arrow should be determined automatically depending on the position of the screen.
Also, there should be support for showing the tooltip in another place if it doesn't fit on the screen in the current one.

[tr1ble]

As far as I remember, the position of the arrow should be determined automatically depending on the position of the screen. Also, there should be support for showing the tooltip in another place if it doesn't fit on the screen in the current one.

I've shown it to UX and got approve

[tr1ble]

Now it's refactored from dynamic (depending on cursor) to static tooltip position depending on element placement on screen

[Vadim73i]

Are inline styles prop (style) used?
May be replace with a className?

[tr1ble]

This style comes from Popper component and it's using for position calucaltion

[Vadim73i]

There should be padding. Like on popover. Ask the designer if the tooltip should be transparent. And fix the strip on the triangle.

[tr1ble]

There should be padding. Like on popover

Yeah, I've though about it and decided that you can pass offsetLeft and offsetTop to get padding. But I can add default 4px value padding for all cases

[tr1ble]

There should be padding. Like on popover. Ask the designer if the tooltip should be transparent. And fix the strip on the triangle.

On design it has 0.95 opacity.
Strip cannot be fixed even with official Popper example

[Vadim73i]

May be set default value with this padding? This is more useful.
And set side: 'auto' as default.

[tr1ble]

May be set default value with this padding? This is more useful. And set side: 'auto' as default.

It has 'auto' by default.

[Vadim73i]

May be set default value with this padding? This is more useful. And set side: 'auto' as default.

It has 'auto' by default.

readme says "- side: string, optional, default = 'top'"

[Vadim73i]

There should be padding. Like on popover. Ask the designer if the tooltip should be transparent. And fix the strip on the triangle.

On design it has 0.95 opacity. Strip cannot be fixed even with official Popper example

But if I change 1 to 0 (withTooltip.scss lines: 93, 113, 134, 155) - it works

[Vadim73i]

And "side: left" shows the tooltip on the right side

[tr1ble]

May be set default value with this padding? This is more useful. And set side: 'auto' as default.

It has 'auto' by default.

readme says "- side: string, optional, default = 'top'"

There should be padding. Like on popover. Ask the designer if the tooltip should be transparent. And fix the strip on the triangle.

On design it has 0.95 opacity. Strip cannot be fixed even with official Popper example

But if I change 1 to 0 (withTooltip.scss lines: 93, 113, 134, 155) - it works

I've tried it already, but I'll recheck thanks

[tr1ble]

There should be padding. Like on popover. Ask the designer if the tooltip should be transparent. And fix the strip on the triangle.

On design it has 0.95 opacity. Strip cannot be fixed even with official Popper example

But if I change 1 to 0 (withTooltip.scss lines: 93, 113, 134, 155) - it works

Anyway it has strip, not black, but white

[tr1ble]

And "side: left" shows the tooltip on the right side

Didn't reproduce. And I don't change default logic, we just pass this prop to Popper

[Vadim73i]

And "side: left" shows the tooltip on the right side

Didn't reproduce. And I don't change default logic, we just pass this prop to Popper

Sorry, I didn't fit the tooltip in width and showed on the right. Everything is working.