Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor CI is failing #1009

Closed
jamessspanggg opened this issue Jan 19, 2020 · 9 comments · Fixed by #1015
Closed

Appveyor CI is failing #1009

jamessspanggg opened this issue Jan 19, 2020 · 9 comments · Fixed by #1015
Labels
c.Investigate p.Urgent

Comments

@jamessspanggg
Copy link
Contributor

jamessspanggg commented Jan 19, 2020 •
edited
Loading

Appveyor CI is current failing in all PRs with the following lines:

Screen Shot 2020-01-20 at 12 42 20 PM

Screen Shot 2020-01-20 at 12 42 42 PM

Link to one of the Appveyor build for PR #1005: https://ci.appveyor.com/project/eugenepeh/reposense/builds/30213033
@jamessspanggg
Copy link
Contributor Author

May be due to AppVeyor's recent Windows image update: https://www.appveyor.com/updates/

@0blivious
Copy link
Contributor

I feel the failed test is actually the 2 below. However, I am unable to reproduce them locally.
image
image

@fzdy1914 fzdy1914 added p.Urgent and removed p.High labels Jan 20, 2020
@fzdy1914
Copy link
Member

@reposense/devs Please help with this issue and try to get it solved quickly.

@fzdy1914
Copy link
Member

image

@jamessspanggg
Copy link
Contributor Author

With the update, using git checkout to a branch with illegal window file names will incur an exception...

@jinyao-lee
Copy link
Contributor

jinyao-lee commented Jan 20, 2020 •
edited
Loading

I actually think that these two test cases are no longer relevant and can be removed.

Reason: in windows, repos and branches that are to be analyzed would have been checked for illegal filenames via gitlstree (from the bare clone) before they are checked out from the bare repo to the actual ones

@jinyao-lee
Copy link
Contributor

jinyao-lee commented Jan 20, 2020 •
edited
Loading

Investigating further, the test cases worked on Git 2.23 (my previous setup before updating) but not on 2.25.

Current version is 2.25 and that's the version that the AppVeyor is now on with the latest update
image
git-for-windows/git#2440

@0blivious
Copy link
Contributor

As updated from Git v2.24, Git for windows would print error for illegal file name and prevent it from adding into index. As in our test cases we run the command git checkout someInvalidName, an exception is expected to be thrown, and since we do not catch it, the test fail. An work around in local machine is to disable core.protectNTFS.

The doc for protectNTFS can be found here. It is set to be true for windows and false for other systems. https://git-scm.com/docs/git-config

Since even the git command will fail on windows, maybe we should remove the 2 tests, or we test if the correct exception is to be thrown

@yong24s
Copy link
Contributor

yong24s commented Jan 20, 2020

Let's remove the two outdated tests.

Well done in the prompt investigation and thank you for the effort 👍.

@0blivious 0blivious mentioned this issue Jan 20, 2020
Merged
fzdy1914 pushed a commit that referenced this issue Jan 21, 2020
@0blivious @fzdy1914
[#1009] AppVeyor Failing: remove outdated tests (#1015)
b40b3e6 
AppVeyor CI is failing in all PRs as it has updated its worker 
image, which uses Git 2.25 instead of Git 2.23.

From Git v2.24, Git for windows would print error for an illegal
file name and prevent it from adding into the index. As in our test 
cases we run the command `git checkout someInvalidName`, an 
exception is expected to be thrown, and since we do not catch it, 
the tests fail. 

Let's remove the 2 outdated test as the git command now handles
detection of invalid filename and will throw exception at the very
beginning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Investigate p.Urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1009] Appveyor Failing: remove outdated tests 0blivious/RepoSense
5 participants
@yong24s @jamessspanggg @fzdy1914 @jinyao-lee @0blivious