Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a way to find repos with a specific tag #2109

Closed
damithc opened this issue Feb 12, 2024 · 3 comments · Fixed by #2116 or #2167
Closed

Give a way to find repos with a specific tag #2109

damithc opened this issue Feb 12, 2024 · 3 comments · Fixed by #2116 or #2167
Assignees
@jonasongg
Labels
c.Feature s.ToDiscuss

Comments

@damithc
Copy link
Collaborator

damithc commented Feb 12, 2024

Suggestion: enhance the search feature to find repos with a specific tag e.g, tag:A-JUnit
image

This is a niche use case but could be useful for courses such as CS2103, for students/instructors to easily find repos which has a specific tag

Not sure how hard it is to implement though.
@jonasongg jonasongg self-assigned this Feb 13, 2024
@jonasongg jonasongg mentioned this issue Feb 16, 2024
Merged
@damithc damithc mentioned this issue Mar 8, 2024
Closed
ckcherry23 pushed a commit that referenced this issue Mar 19, 2024
@jonasongg
[#2109] Add search by tag functionality (#2116)
147f473 
Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags.
@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap Mar 19, 2024
ckcherry23 added a commit that referenced this issue Mar 19, 2024
@ckcherry23
Revert "[#2109] Add search by tag functionality (#2116)"
0458add 
This reverts commit 147f473.
ckcherry23 added a commit that referenced this issue Mar 20, 2024
@ckcherry23
[#2164] Revert "[#2109] Add search by tag functionality" (#2165)
cc0651f 
Reverts PR #2116 to fix single group bug

Merging PR #2116 has caused all analysed charts to appear in a single group. 

Let us revert that merge commit as a hotfix to restore the original behaviour
while we investigate a solution.
@ckcherry23 ckcherry23 reopened this Mar 20, 2024
@ckcherry23
Copy link
Member

@jonasongg Based on the issue reported in #2164, can you investigate what went wrong and reopen a PR for this?

To the RepoSense team:
Although the merged PR successfully implemented the required search-by-tag functionality with adequate test cases, it inadvertently broke unrelated functionality. This oversight occurred because the data seemed to be intended that way, leading to its unnoticed impact.

This is because our end-to-end tests mainly focus on testing features rather than data representation. To avoid this in the future, we could do the following:

  • Data-driven testing: Add tests to check if the actual JSON data is being represented in the expected manner.
  • Snapshot testing: Implement snapshot testing to ensure there are no visual regressions.

@jonasongg
Copy link
Contributor

@ckcherry23 I just investigated this and think I found what is causing the bug. How should I reopen a PR for this fix - should I push to the same branch as I did originally and keep the commit message the same (including the fact that it includes a bug fix)?

As for how to include different testing techniques for our frontend, maybe it'd be best to discuss in-person on Monday with the rest of the team!

@ckcherry23
Copy link
Member

@ckcherry23 I just investigated this and think I found what is causing the bug. How should I reopen a PR for this fix - should I push to the same branch as I did originally and keep the commit message the same (including the fact that it includes a bug fix)?

@jonasongg Yes, you can push to the same branch as the merge commit was fully reverted. You can keep the commit message the same (and add the bug fix part if needed).

@jonasongg jonasongg mentioned this issue Mar 22, 2024
Merged
ckcherry23 pushed a commit that referenced this issue Apr 1, 2024
@jonasongg
[#2109] Add search by tag functionality (#2167)
b139a95 
Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags. This
commit also fixes a bug that existed in a previous version of the
feature which resulted in all users being shown to belong to same group.
georgetayqy added a commit that referenced this issue Apr 4, 2024
@sopa301 @georgetayqy
@dependabot @jonasongg
Add blurbs on frontend (#2186)
6c5e401 
* [#2120] Update RepoSense contributors in documentation (#2138)

The current About page on the RepoSense docs does not reflect the
updated list of developers working on RepoSense.

Let's move to update the list to more accurately reference the current
developers of RepoSense.

* [#2001] Extract c-zoom-commit-message component from views/c-zoom (#2132)

Many of the frontend files are difficult to navigate through due to the
large file sizes. As we add more features to the frontend, it is
getting harder to maintain. This is also very unfriendly towards new
contributors. 

Let us break down frontend files in a logical manner, continuing with
extracting c-zoom-commit-message from views/c-zoom.

* [#2142] Fix Vulnerabilities (#2143)

Fix vulnerabilities in codebase.

There are existing vulnerabilities in the codebase.

Let's fix as many as possible.

* Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend (#2160)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /frontend (#2168)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

* [#2151] Update LoadingOverlay and Minor Versions of Node Dependencies (#2152)

Update LoadingOverlay and Minor Versions of Node Dependencies

Some dependencies are not at their latest minor or patch releases.

Let's update these dependencies, as well as LoadingOverlay as part of a
bug fix.

* Factor out markdown parser

* [#2109] Add search by tag functionality (#2167)

Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags. This
commit also fixes a bug that existed in a previous version of the
feature which resulted in all users being shown to belong to same group.

* Refactor chunks

* Fix style

* Add parts of blurb

* Fix linting

* Fix style

* Fix missing html parsing

* Remove unused import

---------

Co-authored-by: George Tay <george_tay@u.nus.edu>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonasongg <120372506+jonasongg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasongg jonasongg

Labels
c.Feature s.ToDiscuss
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
3 participants
@damithc @ckcherry23 @jonasongg