Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Vue CLI to fix GitHub Pages Deployment #2203

Merged
merged 1 commit into from
May 14, 2024

Conversation

ckcherry23
Copy link
Member

Reverts #2178 to fix #2202

Proposed commit message

Revert to Vue CLI to fix GitHub Pages Deployment

Although Vite boasts better performance and is maintained actively,
its usage for GitHub Pages deployment requires specifying the base of the
deployment URL in the config. This makes it inconvenient as all existing
deployment dashboards must update the base respective to their URLs.  

Let's revert to Vue CLI temporarily to fix this.

Other information

Deploying sites built with Vite on GitHub Pages requires configuring the base in vite.config.js as the subdirectory (or repository name) where the report is deployed (eg. /ip-dashboard/). However, since RepoSense reports will be deployed on multiple GitHub Pages URLs, this will require all users to define a new environment variable to specify the custom base, which is not ideal.

We need to decide if we should just revert the migration PR or introduce the env variable into the Vite config. For now, I have reverted the PR. Feel free to suggest alternatives.

@ckcherry23 ckcherry23 requested review from a team May 14, 2024 00:07
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll look into a fix!

@vvidday vvidday merged commit 170e951 into master May 14, 2024
15 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated report is blank
3 participants