-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission for Issue #120 #151
base: master
Are you sure you want to change the base?
Conversation
Hi, please find below a review submitted by one of the reviewers: Score: 8 |
Hi, please find below a review submitted by one of the reviewers: Score: 4 The reproducibility study considers the same hyperparameters as the original work for most of the results presented. There is a sub-section that considers interaction between a key parameter of PADAM (“p”) and the learning rate, which is novel. Unfortunately results for this were not finished and the plots only show a small number of training iterations; not enough to draw useful conclusions. In the other experiments, the reproducibility study follows directly from the original paper. I was surprised to see that the reproducibility study did not comment more on some differences. For example, the test error in Fig.2 of the reproducibility study seems to have much more variance than corresponding plots in Fig.2 of the original work. Do you agree with this observation? Is there a reason for this? Same comment for Fig.4 of the reproducibility study vs Fig.1 of the original work. In this latter case the error also seems higher in the reproducibility study (not just the variance). Finally, comparing Table 2 in the reproducibility study and Table 1 in the original work, it seems learning is slower in the reproduced work, especially looking at the accuracy at epoch 50. Can you discuss these differences? Overall, the reproducibility study does not make specific recommendations to the authors, except to note that it would be a good direction to further explore how to set the hyper-parameter “p” in PADAM. The paper would be improved by a more in-depth discussion of results throughout. Confidence : 4 |
Hi, please find below a review submitted by one of the reviewers: Score: 5 |
#120
Participant Information