Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deployment #85

Merged
merged 26 commits into from
May 27, 2021
Merged

Simplify deployment #85

merged 26 commits into from
May 27, 2021

Conversation

twinkarma
Copy link
Collaborator

@twinkarma twinkarma commented May 21, 2021

Summary

Removed unnecessary dependencies and simplifying project structure to allow ease of deployment and maintenance

Closes #84, closes #83, closes #82, closes #78, closes #70, closes #66, closes #61, closes #52, closes #27, closes #79, closes #69, closes #65, closes #64, closes #63, closes #62

List of changes proposed in this PR (pull-request)

  • Removed dependencies
    • Celery
    • Flower
    • Traefik
    • Redis
    • django leaflet which depends on gis json which depends on libgdal (C++) lib
    • docker compose, recommend using conda or virtualenv instead
    • possibly more
  • Merged reprohack_hub and user apps into one to simplify the project structure
  • Used js-only leaflet, added custom django form widget that utilises that
  • Changed geom field (gis json) into an event_coordinate field (string) that accepts lat and long in a comma separated format e.g. 10.00939,20.93003
  • Navigation bar now has a solid background, so that content without the broadcam header style doesn't appear behind it.
  • Static files: Restructuring of CSS and JS packages
    • Added a reprohack_hub/static/vendor folder for third party libraries
    • Main packages e.g. JQuery, Bootstrap are managed by npm, the entire package is copied to the reprohack_hub/static/vendor/node_modules folder on gulp build. This ensures that nodejs is not needed at deployment.
  • Using sqlite for local dev and mysql for pythonanywhere deployment
  • Replace .env config with a config/settings/secret.py & secret_default.py instead
  • Updated readme on how to run the app locally and deploying on pythonanywhere, removed the .rst version.
  • Added GH workflow for CI, removed travis
  • Many other minor fixes.

What should a reviewer concentrate their feedback on?

  • Does the app work locally?
  • Are the readme instructions clear, any missing instructions?

@twinkarma twinkarma requested a review from annakrystalli May 27, 2021 15:00
Copy link
Member

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks AMAZING to me!!!!

@twinkarma twinkarma merged commit ce62d6d into dev May 27, 2021
@twinkarma twinkarma deleted the simplify-deployment branch May 27, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment