Bugfix for problem with activating new memberships in grace period #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t changeover do the cancellation and new membership
|
Changed behaviour not while the new membership is created, but how the old membership is cancelled and the changeover is handled. It works for the yearly abo changeover, but we need to make sure it works for other changeovers as expected. |
…ips are cancelled immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug: when a new membership is bought during the grace period, the old membership is cancelled immediately because the old membership is overdue, but the new membership is not activated because the old membership is still active.
Proposed fix: the old membership is not cancelled immediately, the new membership is added as dormant, and the changeover scheduler handles the transition